Add in support for FIXED_LEN_BYTE_ARRAY as binary #8404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <[email protected]>
jlowe
previously approved these changes
May 26, 2023
3 tasks
|
The dependent PR is still in draft. I will move this to 23.10 when the dependent PR is also updated to 23.10 |
|
The dependency was merged into CUDF last night, but the CI failed so we might need to wait a little longer before this is ready to test. |
|
build |
|
build |
|
@jlowe could you take another look? |
jlowe
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on rapidsai/cudf#13437
This fixes #7449
The is to support https://issues.apache.org/jira/browse/SPARK-41096 in the plugin. It went into 3.4.0 so these changes and tests are specific to 3.4.0, although some of the back end support in this patch goes into a 3.3.0+ shim, but Spark itself tends to prevent this from happening in anything beyond 3.4.0. I did not thoroughly test this though and if we want more tests/verification that this is going to work I am happy to do that.
I wrote this because the author of rapidsai/cudf#13437 asked me to test it, and this was the simplest way to test it.